[Xen-devel] Re: [PATCH]: xl: catch invalid numeric domain ID

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andre Przywara writes ("[PATCH]: xl: catch invalid numeric domain ID"):
> if you run any domain specific xl command with an invalid (aka 
> non-existing) numeric domain ID, the command does not abort, but 
> proceeds with some bogus number:

Thanks, but I'm not 100% convinced that it is impossible to ever get
into a situation where a domain exists but has no name.  In that case,
this patch of yours would leave an undestroyable domain.

I think the right answer is to use libxl_domain_info to check whether
the domain exists.  It returns ERROR_INVAL, without logging anything,
if the domain does not exist.  On other failures xl destroy should
probably carry on and attempt to destroy the domain.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel