Re: [Xen-devel] [PATCH] xl: Perform minimal validation of virtual disk file while parsing config file

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Wed, 2011-01-26 at 11:48 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH] xl: Perform minimal validation 
> of virtual disk file while parsing config file"):
> > With this patch applied I get an error using an LVM device via file://
> > (which is currently necessary on upstream dom0 support in order to
> > activate the qdisk support):
> 
> Hrm.  I think the toolstack should really not depend on the user to
> write "file:" some of the time and "phy:" the rest of the time
> according to arcane rules.
> 
> But it's probably too late to fix this properly for 4.1.  In 4.2 xl
> should parse "phy:" and "file:" to PHYSTYPE_PLAIN or something and
> then libxl decide for itself what to do based on backend we are going
> to use and whether the object is a block device.

I think the original rationale for the need to do this was the lack of a
good way to tell if blkback is available on the current host. phy://
becomes blkback whereas file:// becomes blktap whose absence we detect
and fallback to qdisk.

I agree that we should try and do better for 4.2 though.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel