[Xen-devel] xenstore index reset in xb_init_comms breaks domU kdump

[Olaf Hering <olaf@xxxxxxxxx>]

Keir,

in the commit below a reset of the rsp_cons/rsp_prod index was added.
http://xenbits.xen.org/staging/xen-unstable.hg?rev/1ec0d322402e

Is this reset really required for save/restore? I have not tried it, but
I would assume a restored guest would get an empty page to work with.
Also:
Could a guest be saved when its in the middle of a xenstore operation?

The reset breaks the xenstore interface in a crashed domU kernel. If the
crash kernel boots, it tries to operate on the new rsp_* index. But this
contains garbage, process_msg() tries to use the data as 'struct
xsd_sockmsg', and kmalloc() fails.
If I remove the rsp_cons/rsp_prod reset in xb_init_comms(), the PV
drivers in the crash kernel can connect to xenstore.

Should the fixup code be removed, or is it essential for save/restore?


Olaf


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel