RE: [Xen-devel] 2.6.32.27 dom0 + latest xen staging boot failure

["Kay, Allen M" <allen.m.kay@xxxxxxxxx>]

> Can I put a Tested-by on it from you?

Sure.  I have attached the Stefano's patch I used just to make sure that we are 
referring to the same patch.

I would also like to use 2.6.38.  What commands should I use to pull it?  It is 
not clear to me from readying pvops wiki page 
(http://wiki.xensource.com/xenwiki/XenParavirtOps).

-----Original Message-----
From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@xxxxxxxxxx] 
Sent: Wednesday, January 26, 2011 1:29 PM
To: Kay, Allen M
Cc: xen-devel
Subject: Re: [Xen-devel] 2.6.32.27 dom0 + latest xen staging boot failure

On Wed, Jan 26, 2011 at 10:46:13AM -0800, Kay, Allen M wrote:
> I just tried it and it can now boot successfully without the need for 
> dom0_mem=max:1024MB parameter.

Woot! Great.
> 
> Is the patch going to be checked into pvops tree?  It does not seems to be in 
> 2.6.32.27 dom0 pvops tree yet.

It is 2.6.38. Hadn't yet done it for 2.6.32 - let me spin up a patch for it.
Can I put a Tested-by on it from you?

> 
> -----Original Message-----
> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@xxxxxxxxxx] 
> Sent: Wednesday, January 26, 2011 8:14 AM
> To: Kay, Allen M
> Cc: xen-devel
> Subject: Re: [Xen-devel] 2.6.32.27 dom0 + latest xen staging boot failure
> 
> On Tue, Jan 25, 2011 at 06:41:30PM -0800, Kay, Allen M wrote:
> > I noticed one of my e820 entry is not page aligned:
> > 
> > > (XEN)  0000000000000000 - 000000000009bc00 (usable)
> > 
> > It might be similar to the problem reported by Michael Young in attached 
> > email.
> 
> Did you try their patch?
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

--- Begin Message ---

• To: M A Young <m.a.young@xxxxxxxxxxxx>
• From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
• Date: Tue, 25 Jan 2011 04:03:45 -0800
• Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
• List-id: Xen developer discussion <xen-devel.lists.xensource.com>
• Thread-index: Acu8h9vZDL/szN01Say51cWa1/JhCw==
• Thread-topic: [Xen-devel] Crash on boot with 2.6.37-rc8-git3

On Mon, 24 Jan 2011, M A Young wrote:
> On Mon, 24 Jan 2011, Konrad Rzeszutek Wilk wrote:
>
> > We can fix how the E820 is done.
> > Look in arch/x86/xen/setup.c for 'xen_memory_setup' function.
> > Try to wrap make map[i].size be = map[i].szie & ~(PAGE_SIZE-1)
> > that should trim off the last 2048 bytes.
>
> The attached patch works for me, though it does assume the memory region
> starts on a page boundary.

It turns out that it is me having the same issue you have and not the
other way around :)

Your patch (in addition to my previous patch) makes my testbox boot, no
matter what dom0_mem parameter I choose.

Appended is a version of the patch that doesn't assume that the memory
region starts on a page boundary.

---

diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index b5a7f92..a3d28a1 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -179,7 +179,10 @@ char * __init xen_memory_setup(void)
        e820.nr_map = 0;
        xen_extra_mem_start = mem_end;
        for (i = 0; i < memmap.nr_entries; i++) {
-               unsigned long long end = map[i].addr + map[i].size;
+               unsigned long long end;
+               if (map[i].type == E820_RAM)
+                       map[i].size -= (map[i].size + map[i].addr) % PAGE_SIZE;
+               end = map[i].addr + map[i].size;

                if (map[i].type == E820_RAM && end > mem_end) {
                        /* RAM off the end - may be partially included */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

--- End Message ---

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel