Re: [Xen-devel] [PATCH] xl: Special case tap/aio for disk validation

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Kamala Narasimhan writes ("Re: [Xen-devel] [PATCH] xl: Special case tap/aio for 
disk validation"):
> Attached is a first stab at this for your perusal.  It is mostly
> based on the discussion we had in this thread.  Please let me know
> any/all changes you would recommend.

Thanks.  I concur with Ian Campbell's comments, but I have some of my own:

> At a higher level, xl disk configuration option takes the following format:
> 
>     disk = [ 'format:path,vdev:type,attrib', 'format:path,vdev:type,attrib', 
> ... ]

I think Ian's comments about using [ ] for optional elements are very
apposite.  If it's too confusing because of the surrounding
pythonesque [ ] you could try something like
   disk = [ 'disk-spec', 'disk-spec' ]
   where disk-spec is
   [format:]path,vdev[:type][,attribute]
(or whatever is actually true).

Also as well as the doc needing to stay within 70-75 columns, and
certainly within 79, it would be sensible for your emails to do so too
as it makes them easier to read in "traditional" clients.


> Description:         Block device or image file path.  For a physical block 
> device a /dev will be prepended when not specified and when the path doesn't 
> start with a '/'.
> Supported values:    N/A
> Deprecated values:   N/A
> Mandatory:           Yes

I think in fact it's not mandatory because for removeable devices it
can be specified as empty to mean "removed".


> Description:         Virtual device as seen by the guest (also referred to as 
> guest drive designation in some specifications).

It would be sensible refer here to my virtual disk specification doc.


On which subject you wrote:
> IanJ - I am also unable to find the txt doc mentioned in the link
> above.  Please could you confirm whether or not this txt file is
> likely to be added, if not why and whether there are other relevant
> docs for reference?  I will add then all to a "Reference" or
> "Related documents" section.

The document in that url which Ian refers to
  http://lists.xensource.com/archives/html/xen-devel/2010-09/msg01329.html
was never checked into the Xen tree.

There was a bit of discussion about it but I never got a clear ack.
If someone would like to give me an ack now I will commit it :-).

> Supported values:    hd[x], xvd[x]

As you'll see from the doc, it's a bit more complicated than that.


Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel