[Xen-devel] [PATCH] xl: output illegal option character

[Andre Przywara <andre.przywara@xxxxxxx>]

On 01/28/2011 06:57 PM, Ian Jackson wrote:
> > By the way: some command parsers totally omit the faulting character and
> > just output "option not supported."
> > Would you still accept a patch which turns all of those occurrences into
> > the upper, more verbose form?
> Hrm, I'm not sure.  I guess if the patch is very very obvious.
What do you think about the attached one? Looks quite obvious to me.
> > Especially as those conditions are not considered fatal and the command
> > execution continues anyway, I found it rather confusing to read an
> > unspecific error message without giving me a clue what I did wrong.
> TBH I think it is a bug when unknown options are not fatal.  But
> it's probably not sensible to change this now.
Looking at the two patches I hope I can refactor the option parsing into 
common code after the release. This should be easier to fix then.
Regards,
Andre.

----------
Though illegal characters on xl command lines are catched, the user 
isn't currently informed which one was not right.
This patch fixes this by printing the faulting character.

Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>


--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany

Attachment: xl_output_illegal_character.patch
Description: xl_output_illegal_character.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel