Xen project Mailing List

Re: [Xen-devel] [PATCH] xl: fix broken cpupool-numa-split (part 2)

To: Andre Przywara <andre.przywara@xxxxxxx>

From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>

Date: Mon, 31 Jan 2011 07:56:27 +0100

Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Delivery-date: Sun, 30 Jan 2011 22:57:28 -0800

Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=sBxI1qiGZpVPj+Gz7bxfAYDtvD3/NSUaNwt2YSFbFa8RHegONajl1Hv6 wKZYJHU8MUIRedk0Nphr+WgcbTPx1QZYhydeCYmv/xIFn8O1asU0QApF+ UJKQNJsPBsa3WmOK6IEGc4HuowqNjOf1IgOwBhjCsJiVTY3rfzRa4qLT3 eXezc4CYAOIeKl+17WSJs+V8HtoJ0Ac26BVFdbrAhYLmL+7nHYCXuZfiG /DrwyRlRS8wxc/wOIvVGExlmis5SI;

List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 01/29/11 01:35, Andre Przywara wrote:

On 01/28/2011 07:26 AM, Juergen Gross wrote:

On 01/27/11 22:36, Andre Przywara wrote:

Hi,

the implementation of xl cpupool-numa-split is broken. It basically
deals with only one poolid, but there are two to consider: the one from
the original root CPUpool, the other from the newly created one.


Uhh, silly copy and paste error! I think it happened when I introduced
libxl_cpupool_cpuadd_node()...
The correction is much easier. The root poolid is always 0.

Why do you save this value then?
poolid = poolinfo[0].poolid;
Reading this made me think it can be an arbitrary value.

Sorry, must be a relict...

See attached patch.

Easier, but that only solves one part of the problem (not populating the
newly created pool). The second bug still persists, because poolid is
not zeroed out again after the first creation. So the second iteration
will try to reuse the just assigned value and abort with an error.

Ian, please apply the attached patch on top of Jürgens one.

----------
Before the creation and population of a new CPU pool we have to clear
the poolid variable, which still contains the value from the previous
iteration.
This fixes the execution of xl cpupool-numa-split on machines with more
than two nodes.

Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>

Acked-by: juergen.gross@xxxxxxxxxxxxxx -- Juergen Gross Principal Developer Operating Systems TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@xxxxxxxxxxxxxx Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.