[Xen-devel] Re: [xen-unstable test] 5482: regressions - FAIL

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Jackson writes ("[xen-unstable test] 5482: regressions - FAIL"):
>  test-i386-i386-xl-win         5 xen-boot                 fail    like 5237

This is a Xen crash.

BUG was in xen/arch/x86/x86_32/pci.c:pci_conf_read32
    28  uint32_t pci_conf_read32(
    29      unsigned int bus, unsigned int dev, unsigned int func, unsigned int 
reg)
    30  {
    31      BUG_ON((bus > 255) || (dev > 31) || (func > 7) || (reg > 255));

Called from xen/drivers/passthrough/vtd/quirks.c:pci_vtd_quirk.
pci_vtd_quirk says:
   363          val = pci_conf_read32(bus, dev, func, 0x1AC);

I note that the "reg" value 0x1AC is >255 so this code will always BUG
if the quirk code is triggered.

CC'ing Allen Kay whose c/s 22751:93e7bf0e1845
"vt-d: quirks for Sandybridge errata workaround, WLAN, VT-d fault escalation"
seems responsible.

Ian.

Jan 29 11:41:15.493646 (XEN) Xen BUG at pci.c:31
Jan 29 11:41:18.069664 (XEN) ----[ Xen-4.1.0-rc3-pre  x86_32p  debug=y  Not 
tainted ]----
Jan 29 11:41:18.078659 (XEN) CPU:    0
Jan 29 11:41:18.078671 (XEN) EIP:    e008:[<ff1db99a>] pci_conf_read32+0x30/0x73
Jan 29 11:41:18.082648 (XEN) EFLAGS: 00010212   CONTEXT: hypervisor
Jan 29 11:41:18.090705 (XEN) eax: 00000000   ebx: 000001ac   ecx: 00000000   
edx: 00000014
Jan 29 11:41:18.090723 (XEN) esi: 00000014   edi: 00000000   ebp: ff247a44   
esp: ff247a2c
Jan 29 11:41:18.102663 (XEN) cr0: 8005003b   cr4: 000026f0   cr3: 00213040   
cr2: 00000000
Jan 29 11:41:18.109651 (XEN) ds: e010   es: e010   fs: e010   gs: e010   ss: 
e010   cs: e008
Jan 29 11:41:18.113650 (XEN) Xen stack trace from esp=ff247a2c:
Jan 29 11:41:18.125673 (XEN)    8000a000 00000000 00000004 ff136fa1 00000000 
00000000 ff247a74 ff13dab5
Jan 29 11:41:18.125694 (XEN)    00000000 00000014 00000000 000001ac ff213868 
00000292 ff213868 ffbfce18
Jan 29 11:41:18.137659 (XEN)    000000a0 00000000 ff247aa4 ff221dc5 ffbfce18 
000000a0 ff247ab4 ff1259f9
Jan 29 11:41:18.145666 (XEN)    00000010 ffbfe000 ffb82228 00000001 00000000 
ffb82000 ff247ad4 ff2217e3
Jan 29 11:41:18.150736 (XEN)    ffb82000 ffba1e18 ff247ad4 ff113cdd ffb85c64 
00000004 ffb85c64 00000001
Jan 29 11:41:18.150757 (XEN)    00000000 00000001 ff247e54 ff22a611 ffb82000 
000fec80 000fec80 00000020
Jan 29 11:41:18.162665 (XEN)    ff1fefeb c55d6000 c5656000 c5656000 c565647c 
c5657000 c5688000 c5688000
Jan 29 11:41:18.170658 (XEN)    c5689000 c0000000 c5800000 00000020 ff247b50 
01e1e000 ff247b50 000055d6
Jan 29 11:41:18.170686 (XEN)    00025c3e 00025c3d 00000004 00000000 00005800 
01e19000 25a19000 01247b68
Jan 29 11:41:18.185671 (XEN)    00000000 00000000 00000000 00000000 00225bc2 
00020000 00000031 00224000
Jan 29 11:41:18.190661 (XEN)    00226000 00001998 00230000 c5656000 ff2e8000 
03c3d200 01e4a000 01e19000
Jan 29 11:41:18.202654 (XEN)    01e1d160 c1000000 c1998000 c1998000 c55d5200 
c55d6000 c5656000 c5656000
Jan 29 11:41:18.202682 (XEN)    c565647c c5689000 c5657000 c5688000 c0000000 
c5800000 25a19000 00000002
Jan 29 11:41:18.213665 (XEN)    ff11f799 7fffffff 7fffffff 00000000 ff265144 
00005c3d ff250000 01e1d158
Jan 29 11:41:18.225658 (XEN)    25a4a000 00000002 03c3e1ff 00003c3e 01e19000 
01e1a000 01e1a000 00005800
Jan 29 11:41:18.225686 (XEN)    00000031 05800000 00005c3e fd0bfffc 00000000 
00000008 ff247d04 ff23d820
Jan 29 11:41:18.230672 (XEN)    00000000 015db294 015db3fc 00000000 00000000 
00000000 00000000 00000001
Jan 29 11:41:18.242661 (XEN)    ff238a47 c16f5000 00000000 00000001 ff238a5e 
c1002000 00000000 00000001
Jan 29 11:41:18.250656 (XEN)    ff238a38 c0000000 00000000 00000001 ff238a51 
00000000 00000000 00000002
Jan 29 11:41:18.250682 (XEN)    ff238aeb 015db2d0 00000000 00000002 ff2389f8 
015db2a4 00000000 00000002
Jan 29 11:41:18.262674 (XEN) Xen call trace:
Jan 29 11:41:18.262695 (XEN)    [<ff1db99a>] pci_conf_read32+0x30/0x73
Jan 29 11:41:18.270670 (XEN)    [<ff13dab5>] pci_vtd_quirk+0x65/0x93
Jan 29 11:41:18.270694 (XEN)    [<ff221dc5>] intel_iommu_dom0_init+0x9e/0x192
Jan 29 11:41:18.285657 (XEN)    [<ff2217e3>] iommu_dom0_init+0xba/0xc2
Jan 29 11:41:18.285679 (XEN)    [<ff22a611>] construct_dom0+0x1a76/0x1a95
Jan 29 11:41:18.290653 (XEN)    [<ff232189>] __start_xen+0x21ad/0x2204
Jan 29 11:41:18.290676 (XEN)    [<ff10006c>] __high_start+0x58/0x5a
Jan 29 11:41:18.290699 (XEN)    
Jan 29 11:41:18.290709 (XEN) 
Jan 29 11:41:18.290718 (XEN) ****************************************
Jan 29 11:41:18.301660 (XEN) Panic on CPU 0:
Jan 29 11:41:18.301678 (XEN) Xen BUG at pci.c:31

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel