Re: [Xen-devel] Re: [PATCH] xen: Pack some hvmop memory structures better

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 16:35 +0000 on 04 Feb (1296837332), George Dunlap wrote:
> On Fri, Feb 4, 2011 at 4:30 PM, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
> > It only breaks the ABI between xen and tools, which are supposed always
> > to be version-matched.  I'm not sure that it's particularly worthwhile
> > though - at first glance it's saving about ten bytes of argument space.
> > Unless these operations are happening in large batches?
> 
> It's mostly about just making things cleaner.  It does, however, have
> the advantage that the hvmop structure then fits within 7 32-bit
> words; and thus can be simply copied directly into a xentrace record,
> rather than having to be marshalled on a per-hvmop basis.

That's good enough for me.  Also, I see Keir's applied it already. :)

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel