Re: [xen-devel][PATCH 3/5] xl disk configuration parsing changes

[Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>]

>> -#define DSTATE_INITIAL   0
>> -#define DSTATE_TAP       1
>> -#define DSTATE_PHYSPATH  2
>> -#define DSTATE_VIRTPATH  3
>> -#define DSTATE_VIRTTYPE  4
>> -#define DSTATE_RW        5
>> -#define DSTATE_TERMINAL  6
>> +#define DSTATE_INITIAL           0
>> +#define DSTATE_ATTRIB_PARSED     1
>> +#define DSTATE_VDEV_PARSED       2
> 
> Why did you need to remove 4 states?
I didn't have a need for it.

> Also it would be nice to split this patch in two: a patch that
> introduces parse_disk_attrib, parse_disk_vdev_info, etc, and a second
> patch that makes any necessary changes to the state machine.
> Otherwise it is very difficult to understand the reason behind each
> change to the state machine.
>
That might be a little tricky.  I will talk to you on this offline.

>>  static int parse_disk_config(libxl_device_disk *disk, char *buf2)
>>  {
> 
> There doesn't seem to be a way to set DISK_FORMAT_EMPTY anymore, in fact
> a config line like ',hdc:cdrom,w' seems to be broken.
> 
Patch 5/5, validation code should take care of it.

Kamala

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel