[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: suppress HPET broadcast initialization in the presence of ARAT


  • To: "Wei, Gang" <gang.wei@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Sat, 12 Feb 2011 07:35:22 +0000
  • Cc:
  • Delivery-date: Fri, 11 Feb 2011 23:36:29 -0800
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=DSGVTRnOEjKJApRwxOUdmKQuFkxlKdE62/wUJKJ0eIubfolCurkkJbq77xCr3nVT9z SfdOxE1w6jeUyr17J+sVlPr59T1zE2j+2ROWmgN9XEQnyB06Gw8Cnt4TyrzYEGqyOXsk vcNt13VEffQruCmy2lBIzZe0yT4ZCp5zP9Xy8=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcvJKtjJC1MX3WdtTkmBlr8Ula8GDwBWM7pwAADwAnM=
  • Thread-topic: [Xen-devel] [PATCH] x86: suppress HPET broadcast initialization in the presence of ARAT

On 12/02/2011 07:15, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:

> Jan Beulich wrote on 2011-02-10:
>> This follows Linux commit 39fe05e58c5e448601ce46e6b03900d5bf31c4b0,
>> noticing that all this setup is pointless when ARAT support is there,
>> and knowing that on SLED11's native kernel it has actually caused S3 resume
>> issues.
>> 
> 
> Although this patch was already checked in, I still have to say it is not
> necessary for Xen. Because hpet_broadcast_init() fn is only called if
> (xen_cpuidle && !boot_cpu_has(X86_FEATURE_ARAT)) in disable_pit_irq(). Of
> course I agree to keep it as a never used double check.

Hmm I didn't spot that. Actually it is part of a more complex series of
checks in the caller, so I wonder whether repeating just that one check in
the function itself really makes much sense. I'm somewhat inclibned to
revert it.

 -- Keir

> Jimmy
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.