Re: [Xen-devel] [PATCH] Remus: support both tap and tap2 style disk specs

[Shriram Rajagopalan <rshriram@xxxxxxxxx>]

On Thu, Feb 17, 2011 at 11:04 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Shriram Rajagopalan writes ("[Xen-devel] [PATCH] Remus: support both tap and 
> tap2 style disk specs"):
>> Remus: support both tap and tap2 style disk specs
>
> Thanks for this, but: where can I find documented what this disk spec
> string is supposed to look like ?  Ought this to be in
> docs/misc/xl-disk-configuration.txt ?
>
>> -        if not disk.uname.startswith('tap:remus:') and not 
>> disk.uname.startswith('tap:tapdisk:remus:'):
>> +        disktype = re.match("tap2?:.*(remus.*)\|", disk.uname)
>> +        if disktype == None:
>
> This seems quite a striking change.  What is the tap2 remus syntax
> like ?
>
There is no change in remus syntax.
remus part of the disk spec just requires "remus:BackupHost:Port|" to
immediately follow major driver name. so,

 disk= tap2:remus:BackupHost:Port|aio:volname ...

the problem is with the initial prefix "tap2:" string.
Which could be tap: or tap2: or tap:tapdisk or tap2:tapdisk based on
http://wiki.xensource.com/xenwiki/blktap2

Though as i noted in an earlier email, libxl doesnt accept tap2 while xend
accepts tap2.

shriram
> Ian.
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel