Re: [Xen-devel] Re: [Qemu-devel] [PATCH V10 06/15] xen: Add the Xen platform pci device

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2011-02-24 at 17:36 +0000, Paolo Bonzini wrote:
> >> +/* Send bytes to syslog */
> >> +static void log_writeb(PCIXenPlatformState *s, char val)
> >> +{
> >> + if (val == '\n' || s->log_buffer_off == sizeof(s->log_buffer) -
> 1) {
> >> + /* Flush buffer */
> >> + s->log_buffer[s->log_buffer_off] = 0;
> >> + DPRINTF("%s\n", s->log_buffer);
> >
> > This should go to a chardev.
> 
> Or it should just go away.  Guests can already write to 0xe9 and see
> the output on the host's "xm dmesg" ring and serial console. 

Only true if you have configured the guest log level to include debug
messages.

In any case host dmesg is not really the same as going to a file in dom0
from a supportability PoV.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel