[Xen-devel] Re: [PATCH] Make explicit message when guest failed to suspend

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Thu, 2011-03-03 at 11:22 +0000, Frank Pan wrote:
> > This is a bug in Xend, it should never enter an infinite loop regardless
> > of guest behaviour. The code certainly appears to expect to be managing
> > a timeout, perhaps it has bitrotted?
> >
> > I don't think you can change the xenbus protocol in this way without
> > further rationale regarding it's correctness.
> >
> > Perhaps a separate control/shutdown-error key? The message written
> > should be more verbose than just "failed" if/when more specific
> > information is available to the kernel.
> 
> FP: Maybe I should seperate it into 2 patches? One for bug fixing, the
> other for new protocol?

The patch to xend should be separate in any case -- since the kernel and
xend live in different trees.

also if you are changing the protocol you need to implement it for
libxl/xl as well. so you actually need (are least) two series:

xen-unstable.hg 1/2 -- xend bugfix
xen-unstable.hg 2/2 -- xend+libxl/xl side of protocol change

kernel 1/1 -- protocol change

etc.

> 
> > In particular you need to consider and explain how it remains compatible
> > with a new kernel running on older toolstacks and vice versa.
> >
> 
> FP: Right. This is something I haven't considered yet.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel