[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH 01/14] xen: events: separate two unrelated halves of if condition



Clarifies which bit the comment applies to.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 drivers/xen/events.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index 6befe62..684b095 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -1143,10 +1143,14 @@ static int rebind_irq_to_cpu(unsigned irq, unsigned 
tcpu)
        struct evtchn_bind_vcpu bind_vcpu;
        int evtchn = evtchn_from_irq(irq);
 
-       /* events delivered via platform PCI interrupts are always
-        * routed to vcpu 0 */
-       if (!VALID_EVTCHN(evtchn) ||
-               (xen_hvm_domain() && !xen_have_vector_callback))
+       if (!VALID_EVTCHN(evtchn))
+               return -1;
+
+       /*
+        * Events delivered via platform PCI interrupts are always
+        * routed to vcpu 0 and hence cannot be rebound.
+        */
+       if (xen_hvm_domain() && !xen_have_vector_callback)
                return -1;
 
        /* Send future instances of this interrupt to other vcpu. */
-- 
1.5.6.5


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.