Re: [Xen-devel] [PATCH 2/3] add DomU xz kernel decompression

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>>> Ian Jackson  03/10/11 6:51 PM >>>
>Jan Beulich writes ("[Xen-devel] [PATCH 2/3] add DomU xz kernel 
>decompression"):
>> Signed-off-by: Jan Beulich 
>
>I see this has already been committed, but:
>
>> --- a/tools/libxc/xc_dom_bzimageloader.c
>> +++ b/tools/libxc/xc_dom_bzimageloader.c
>...
>>  {
>> -    lzma_stream stream = LZMA_STREAM_INIT;
>> -    lzma_ret ret;
>>      lzma_action action = LZMA_RUN;
>>      unsigned char *out_buf;
>>      unsigned char *tmp_buf;
>> @@ -152,10 +151,9 @@ static int xc_try_lzma_decode(
>>      int outsize;
>>      const char *msg;
>>  
>> -    ret = lzma_alone_decoder(&stream, 128*1024*1024);
>>      if ( ret != LZMA_OK )
>>      {
>
>I don't think this can possibly be correct.

At the first glance it may look odd, I agree. However, I tested it
and it did work for me. The fact is that "ret" is now getting passed
in by the caller, and the invocation of (in this case) lzma_alone_decoder()
was moved into the (new) caller.

If it's not that aspect of the change, I may need some more
explanation from you as to what you think is wrong.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel