[Xen-devel] Re: [GIT/PATCH v4] xen network backend driver

[Stephen Hemminger <shemminger@xxxxxxxxxx>]

On Thu, 10 Mar 2011 17:02:33 +0000
Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> +struct xenvif {
> +     /* Unique identifier for this interface. */
...
> +     struct net_device_stats stats;
> +

There is already a stats struct in net_device in current kernel
versions, unless there is a compelling reason otherwise
please use that.

Also, you probably want to implement per-cpu and 64 bit
stats.

-- 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel