Re: [Xen-devel] [PATCH 2/12] VTPM mini-os: posix IO layer for blkfront in mini-os

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Matthew Fioravante, le Mon 14 Mar 2011 17:32:31 -0400, a écrit :
> >>>>+     aiocb.aio_cb = NULL;
> >>>Maybe blkfront_aio_cb should do it itself?  It looks odd to have to do
> >>>it when reusing an aiocb structure.
> >>>
> I think I totally misunderstood you. With the last case are you just 
> referring to how I keep having to set the callback to NULL everytime?

Yes.

> If so I totally agree with you. It should just set it back to NULL
> when its done.
> 
> I thought you were talking about how I was handling writes to partial 
> blocks and that somehow the low level blkfront functions should be doing 
> this transparently.

Nope.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel