[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: serial console driver using release_irq()/setup_irq() on suspend/resume


  • To: Jan Beulich <JBeulich@xxxxxxxxxx>
  • From: Keir Fraser <keir.xen@xxxxxxxxx>
  • Date: Thu, 17 Mar 2011 17:01:25 +0000
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 17 Mar 2011 10:02:24 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=YCzVpdoZIFzQ+oUlTYTQefXjV4TG07xb4wX/enPdx/T64yLkXTd8n4J0SKobp+qKWE EusK6WB2Rqc9SI840Npzt3ECPbcMgSyV1g0banX0LkT7vig5+b/JyMdGjtGQLlOm39jw o9r36SNW40Ydgyrfu5F4cQn3GBqqhL/pG1Ftk=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcvkxPLkyJWr6ZUCGEabvgue2TMn6A==
  • Thread-topic: serial console driver using release_irq()/setup_irq() on suspend/resume

On 17/03/2011 16:45, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> Keir,
> 
> is there any particular reason this is being done this way, other than
> having made the change in 15259:35e38c9048c8 very simple? I'm
> asking because in general, with no modules, Xen ought to not need
> setup_irq() post-init (for release_irq() the serial driver is actually the
> only consumer), and after fiddling with request_irq() callers this is
> now the only one needing the function to be in .text.

I expect it was done that way for simplicity, so that resume looks like
boot-time init. Feel free to mess with it and make a more customised
streamlined resume path.

 -- Keir

> Jan
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.