[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/mce: CPU notifiers must not be registered a second time during resume

  • To: Jan Beulich <JBeulich@xxxxxxxxxx>
  • From: Keir Fraser <keir.xen@xxxxxxxxx>
  • Date: Fri, 18 Mar 2011 17:11:51 +0000
  • Cc: Jinsong Liu <jinsong.liu@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 18 Mar 2011 10:13:21 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=m6PZCbwoqPLu2Ug8xZE60lda69WecdsZksQFNGfc+I7VTrs3nAGTHdcXHohPcaSrgR apfB8//gd/TdmMmrGDE65Sn5IGrJQ7TKxd/c+xjkNgqJsmR/IEgy3UMggfbS8P/Evh1I xTwD+fGp1dbep9SDF5opB3KoQ2y53s6PczQks=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acvlj5JuKyfkNpK3CkS4mvXABJFidg==
  • Thread-topic: [Xen-devel] [PATCH] x86/mce: CPU notifiers must not be registered a second time during resume
On 18/03/2011 16:35, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>> if ( !early_init_done ) {
>>  BUG_ON(smp_processor_id() != 0);
>>  ...
>>  early_init_done = 1;
>> }
>> 
>> It's clearer anyway -- we're simply protecting one-time-only early-boot-time
>> initialisation stuff.
> 
> What's wrong with doing the protection by passing down the
> necessary information?

Hm, yes, fair enough, I'll apply it.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.

Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.