Re: [Xen-devel] [PATCH] tools: libxl: translate xvd[a-d] to hd[a-d] for new qemu

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Thu, 2011-03-31 at 19:38 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH] tools: libxl: translate xvd[a-d] to 
> hd[a-d] for new qemu"):
> > tools: libxl: translate xvd[a-d] to hd[a-d] for new qemu
> > 
> > xvde+ are ignored.
> 
> I don't think this is strictly speaking correct.  According to the
> spec doc/misc/vbd-interface.txt, we are supposed to support vdevs in a
> variety of formats.
> 
> What this code ought to be doing is using the parsing function and
> then reconstituting the vdev name for qemu's benefit.

makes sense, I'd forgotten about the parsing function.

I guess for everything other than the sdX syntax I should translate the
result of libxl__device_disk_dev_number into an -hd[a-d] for values < 4
and ignore anything greater, but for sdX syntax I want to pass it
through as is? And is the limit 4 or 16 in that case? (I'm not 100% sure
of the old qemu's behaviour...)

Ian


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel