[Xen-devel] Re: [PATCH 3 of 4] libxl: Add support for passing in the machine's E820 for PCI passthrough in libxl_device_pci_parse_bdf

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Mon, 2011-04-11 at 22:35 +0100, Konrad Rzeszutek Wilk wrote:
> 
> 
> The code libxl_device_pci_parse_bdf calls the libxl__e820_alloc when
> it has parsed one BDF. Subsequent calls to libxl_device_pci_parse_bdf
> will
> not trigger libxl__e820_alloc being called (unless the first call to
> libxl__e820_alloc failed).

That sounds like a very odd non-intuitive location for that allocation.
Why not do it in libxl_domain_create or somewhere like that?

I think the e820 map added to the idl should become a simple boolean
flag and this should all be taken care of internally based on that.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel