[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2 of 4] x86: make the pv-only e820 array be dynamic


  • To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Tue, 12 Apr 2011 14:06:05 +0100
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Ian.Campbell@xxxxxxxxxx, Tim.Deegan@xxxxxxxxxx
  • Delivery-date: Tue, 12 Apr 2011 06:08:17 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=eFuHOMNVux/wRZMlrLJHxTA/XGHevy8P/CySb7i3cEq7QY5oyEkz+AeBa5lwBGENNH GtQq45sOz9dazAjo/NJPTolTJsdha8qXEzoMd6nTlmHx1jgIN1dRXZdUv9Up+JhZNFQ6 C+VCvkXZQDZZ2iNkc59x18ziA39d1qucO8ggQ=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acv5EmF142uLK8B5aEOyIZ8fgTuyyA==
  • Thread-topic: [Xen-devel] [PATCH 2 of 4] x86: make the pv-only e820 array be dynamic

On 12/04/2011 13:53, "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx> wrote:

>> How cunning.
>> 
>> Why wouldn't you just allocate exactly the right size of array in
>> XENMEM_set_memory_map?
> 
> I was thinking about it, but the mm.c code did not have the
> xen/xmalloc.h header, nor any references to xmalloc_array.
> 
> Is it OK to make an xmalloc_array during a hypercall?

Yes. I think the toolstack should be able to clean up on the newly-possible
ENOMEM return from this hypercall.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.