Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 13/04/2011 11:35, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> Cleanup for ASID emulation:
> - Use C99 integer types for asid numbers

> - asid.c: consistently use 'v' instead of 'curr'

On what planet is that an improvement??

We use 'curr' as a convenient idiom to represent cached current. Whereas 'v'
is supposed to represent an arbitrary vcpu.

I know it costs three extra characters per use, but it does make code easier
to understand.

 -- Keir

> - Introduce svm_invlpga() used in ASID emulation patch
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel