Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On 04/13/11 15:28, Keir Fraser wrote:
> On 13/04/2011 14:20, "Christoph Egger"<Christoph.Egger@xxxxxxx>  wrote:
>
> > On Wednesday 13 April 2011 15:06:43 Keir Fraser wrote:
> > > On 13/04/2011 11:35, "Christoph Egger"<Christoph.Egger@xxxxxxx>  wrote:
> > > > Cleanup for ASID emulation:
> > > > - Use C99 integer types for asid numbers
> > > >
> > > > - asid.c: consistently use 'v' instead of 'curr'
> > > On what planet is that an improvement??
> > >
> > > We use 'curr' as a convenient idiom to represent cached current. Whereas
> > > 'v' is supposed to represent an arbitrary vcpu.
> > Oh, that's the difference. I thought 'curr' is just another random name for an
> > arbitrary vcpu.
> >
> > I will resend the patch w/o that hunk.
> I already applied the two cleanups that I didn't mind, as two separate
> changesets.
Thanks.

> And I've nacked your main patch so you can go take a look at
> that. :-)
Just sent my comments.

Christoph


--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel