[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation


  • To: Christoph Egger <Christoph.Egger@xxxxxxx>
  • From: Keir Fraser <keir.xen@xxxxxxxxx>
  • Date: Thu, 14 Apr 2011 11:28:54 +0100
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 14 Apr 2011 03:30:16 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=qmqHpLHC/J/LIjuRwkrl6uyCO7Q8YBeebzzaV0BhthyT8lEfUSPWB+7TbHm8grQBA/ HLQ4oIO3gkp21bZLMjUhuZ7ct/qpOON/6mmPyFKVQRjJpZ0TZBFN0/2V6i/hkOCrtkBJ jgyuIlmCGD2QrwskzOWc/TG7Ml7tddTUWBF60=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acv6jsD4qkU/YC7ibUiuLRuaYdVyiw==
  • Thread-topic: [Xen-devel] [PATCH] nestedhvm: ASID emulation

On 14/04/2011 10:26, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

>> What if nv_n2asid wast last assigned on a previous generation, but nv_n1asid
>> was assigned from the current generation? Then you'd have next_asid>
>> nv_n2asid, but nv_n2asid is stale.
> 
> When the generation changes, next_asid is set back to 1 and the hw TLB
> flushed.
> 
> If next_asid is larger than nv_n2asid then it is reused and this is ok
> since the hw TLB got flushed. It is just important that nv_n1asid never
> gets the same hw ASID assigned and that is what the do { } while loop
> ensures.

What if some other vcpu's nv_n1asid or nv_n2asid got assigned the same HW
asid in this generation as this vcpu's (now stale, as it's from a previous
generation's) nv_n2asid? This PCPU can be interleaving execution of other
HVM VCPUs after all.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.