[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] tools/libxl/libxl__build_device_model_args_new/old: The condition is so strong that user has no chance to disable the vnc


  • To: "Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian.Jackson@xxxxxxxxxxxxx, Ian Campbell <Ian.Campbell@xxxxxxxxxx>
  • From: ZhouPeng <zpengxen@xxxxxxxxx>
  • Date: Fri, 15 Apr 2011 16:34:51 +0800
  • Cc:
  • Delivery-date: Fri, 15 Apr 2011 01:35:47 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=NvshRzyeWskwyNLB7KReLlt/72mNV7eAHlWDr7GMmzMdQ/3CzvagQkWJNS+hYBiMZF V+oouKlSdQC8nTFvhuY8MvAKPsSmQpq8BfCL++uRYGDEjEkGG2bMf5X1sTdb3AuZe5H8 U4f10VFX/178IcwVnfXD0zWh2lFI3TZOdOXeY=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Signed-off-by: Zhou Peng <zhoupeng@xxxxxxxxxxxxxxx>

tools/libxl/libxl__build_device_model_args_new/old: The condition is so strong that user has no chance to disable the vnc,
especially considering what has been done in parse_config_data(),which is not resonable with vnc option in vm-cfg file.
If user explicitly set "vnc=0", vnc should be disabled. User should have the chance to only use sdl, other remote display(spice) even nothing.

diff -r 41879bb8d174 -r 6871474a2a09 tools/libxl/libxl_dm.c
--- a/tools/libxl/libxl_dm.c    Fri Apr 15 09:51:14 2011 +0800
+++ b/tools/libxl/libxl_dm.c    Fri Apr 15 10:06:59 2011 +0800
@@ -55,7 +55,7 @@ static char ** libxl__build_device_model
     if (info->dom_name)
         flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
 
-    if (info->vnc || info->vncdisplay || info->vnclisten || info->vncunused) {
+    if (info->vnc) {
         char *vncarg;
         if (info->vncdisplay) {
             if (info->vnclisten && strchr(info->vnclisten, ':') == NULL) {
@@ -205,7 +205,7 @@ static char ** libxl__build_device_model
     if (info->dom_name) {
         flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
     }
-    if (info->vnc || info->vncdisplay || info->vnclisten || info->vncunused) {
+    if (info->vnc) {
         int display = 0;
         const char *listen = "127.0.0.1";
 

--
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.