Re: [Xen-devel] [PATCH] libxl: fix against if condition

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

ZhouPeng writes ("Re: [Xen-devel] [PATCH] libxl: fix against if condition"):
>   assert( ) here is missleading, I think.
>   In my understanding, assert is offten used to help program debuging,

This code is very much under development, and the lack of support for
vnc passwords is pretty serious problem IMO.

>   telling user the program is runing in exception here and abort it.
>   So, I just think "missing code" means "missing passwd code", which tell
> user must supply an non-empty vnc passwd,

No, the user may *not* supply a non-empty password if they want it to
work.

>   I think an comment like TODO may be more clear,

Certainly the code should fail.  If you supply a good patch which
replaces the assert with a properly logged error return I'll apply it.

But it would be better to implement the missing feature.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel