Re: [Xen-devel] [PATCH] tools: hvmloader: attempt to SHUTDOWN_crash on BUG

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 20/04/2011 19:35, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:

> Ian Campbell writes ("Re: [Xen-devel] [PATCH] tools: hvmloader: attempt to
> SHUTDOWN_crash on BUG"):
>> The toolstack can't tell the difference between hvmloader and the
>> subsequent bootloader then OS doing stuff and they may not be PV'd up.
> 
> Indeed.  But hvmloader can put the reason code back just before it
> launches the guest bootloader (or perhaps just before it enters the
> BIOS).

Currently the reason code cannot be changed after it has been latched by the
hypervisor. Secondly, even if it could be changed, we wouldn't want to
change it to a new value after hvmloader has run; we'd want to reset it to
no-code. That would be cleanest with a new sched_op. However it is arguable
whether this is worthwhile, since I've never heard of hvmloader crashing
except on an explicit bug/assert statement (and even those are rare, and
during development work). So it's kind of a non problem.

Also I already applied Ian's patch. :-) (I still maintain tools/firmware/,
at least until seabios goes in).

 -- Keir

> Ian.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel