Re: [Xen-devel] use of struct hvm_mirq_dpci_mapping.gmsi vs. HVM_IRQ_DPCI_*_MSI flags

[Haitao Shan <maillists.shan@xxxxxxxxx>]

But clarification on the current (perhaps vs intended) use of
HVM_IRQ_DPCI_*_MSI would still be much appreciated (and if,
as suspected, there's need to clean this up, I'd like the cleanup
to be done before the patches I have pending).

Jan, I think the meaning of the flags are pretty straight forward. But I agree with you, we need to clean this up. I don't believe all the flags are necessary at the moment (given the fact that they are introduced by host-MSI-to-guest-INTx translation). But it is still OK for me if they did not cause trouble and were not wrongly used.

I wonder whether the original patch has carefully considered the usage of these flags when it tried to introduce these flags by nature.

 

Basically, I think it is up to you to decide their (flags) future. You are already very careful on this. :) 

 

Shan Haitao 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel