[Xen-devel] RE: [PATCH v2 2/2] x86: don't unmask disabled irqs when migrating them

[Thomas Gleixner <tglx@xxxxxxxxxxxxx>]

On Mon, 9 May 2011, Stefano Stabellini wrote:

> On Mon, 9 May 2011, Tian, Kevin wrote:
> > yes, with your patch this issue disappears, since you explicitly make 
> > mask/unmask as
> > a nop for xen_percpu_chip, which effectively avoids them from undesired 
> > unmask
> > when doing the migration. Though it works, it's not intuitive as to me it's 
> > an
> > workaround to make Xen chip implementation adapting to specific fixup_irqs 
> > logic.
> 
> I have been tring to follow the example of existing supported drivers.
> The only x86 driver I could find that uses handle_percpu_irq is uv_irq
> that does exatly the same thing.

Which is a good enough argument to make that change at the common code
level instead of having fancy workarounds here and there.

Thanks,

        tglx


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel