Re: [Xen-devel] [PATCH 08/14] libxl: disks: new xlu_disk_parse function

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2011-05-12 at 15:36 +0100, Ian Jackson wrote:
> [...]
> +void xlu__disk_err(DiskParseContext *dpc, const char *erroneous,
> +                   const char *message) {
> +    fprintf(dpc->cfg->report,
> +           "%s: config parsing error in disk specification: %s"
> +            "%s%s%s"
> +            " in `%s'\n",
> +           dpc->cfg->filename, message,
> +            erroneous?": near `":"", erroneous?erroneous:"", 
> erroneous?"'":"",
> +            dpc->spec);

Something seems to be up with the leading whitespace here.

[...]
> +   * Normally one would pass nspecs==1 and only specs[0].  But it is
> +   * permitted to pass more strings in which case each is parsed as a
> +   * string containing a collection of parameters (but they all refer
> +   * to of the configuration for a single disk).

           ^^ what is that doing there?

I don't really speak enough flex to have a proper opinion but it looks
plausible enough to me so:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

This is the third time this week I've wondered if a patch ought to come
along with a library of test inputs and expected outputs. I'll be
proposing we switch to the waterfall model before you know it...



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel