Re: [Xen-devel] [PATCH] Fix save.py bug

[Shriram Rajagopalan <rshriram@xxxxxxxxx>]

On Fri, May 13, 2011 at 1:33 PM, Liu, Jinsong <jinsong.liu@xxxxxxxxx> wrote:

Ian Campbell wrote:
> Adding Remus maintainer. You can consult the MAINTAINERS file at the
> top level to fix this.
>
> On Fri, 2011-05-13 at 15:26 +0100, Liu, Jinsong wrote:
>> I don't know python well, but when I compile at my platform, compile
>> error as:
>>
>>
>> =======================
>> ...
>> Parsing libxl.idl
>> cmp: _libxl_paths.h.tmp: No such file or directory
>> cmp: _libxl_paths.h: No such file or directory
>> cmp: xen/util/path.py: No such file or directory
>> Parsing
>>
>>
>> /otc/source/vtd/xen-unstable/tools/python/../../tools/libxl/libxl.idl
>> File "/usr/lib64/python2.4/site-packages/xen/remus/save.py", line
>> 169     finally: ^
>> SyntaxError: invalid syntax
>> ...
>>
>> ======================
>>
>>
>> This kind of compile error introduced from c/s 23195.
>> This patch revert it.
>
> That seems rather extreme in the first instance.
>
> From a quick google It seems that python 2.4 did not properly support
> the "try: ... except: ... finally: ... " syntax. It appears that as a
> workaround one can do
>       try:
>               try:
>                       ...
>               except:
>                       ...
>       finally:
>               ...
>
> But I didn't try this myself.
>
> Ian.

Shriram and Ian,

I update the patch according to Ian's comments, as attached.
Test result shows compiling OK now.

Hi,
sorry for the delay but I was waiting for the xen side bug to get resolved
before testing your patch. It works properly in remus installation.

Acked-by: Shriram Rajagopalan <rshriram@xxxxxxxxx>

Thanks,
Jinsong

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel