Re: [Xen-devel] [PATCH 1/2] Xen: enabling emulated MSI injection

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

Hi, 

At 07:31 +0100 on 26 May (1306395103), Wei Liu wrote:
> 
> +
> +extern void vmsi_deliver(struct domain *d, int vector,
> +                         uint8_t dest, uint8_t dest_mode,
> +                         uint8_t delivery_mode, uint8_t trig_mode);

Please put this declaration in a header file rather than in the C file.
xen/pci.h seems to have some of the other functions from the same file
in it.

> diff --git a/xen/drivers/passthrough/io.c b/xen/drivers/passthrough/io.c
> index 67b0223..848c3e5 100644
> --- a/xen/drivers/passthrough/io.c
> +++ b/xen/drivers/passthrough/io.c
> @@ -452,13 +452,13 @@ void hvm_dpci_msi_eoi(struct domain *d, int vector)
>      spin_unlock(&d->event_lock);
>  }
> 
> -extern int vmsi_deliver(struct domain *d, int pirq);
> +extern int vmsi_deliver_pirq(struct domain *d, int pirq);

Likewise (I know this one was like this already but you might as well
fix it since you're alraedy touching this line).

> diff --git a/xen/include/public/hvm/hvm_op.h b/xen/include/public/hvm/hvm_op.h
> index 2a597da..7617341 100644
> --- a/xen/include/public/hvm/hvm_op.h
> +++ b/xen/include/public/hvm/hvm_op.h
> @@ -240,4 +240,23 @@ struct xen_hvm_get_mem_type {
>  typedef struct xen_hvm_get_mem_type xen_hvm_get_mem_type_t;
>  DEFINE_XEN_GUEST_HANDLE(xen_hvm_get_mem_type_t);
> 
> +
> +/* Following tools-only interfaces may change in future. */
> +#if defined(__XEN__) || defined(__XEN_TOOLS__)
> +
> +/* MSI injection for emulated devices */
> +#define HVMOP_inj_msi         16
> +struct xen_hvm_inj_msi {
> +    /* Domain to be injected */
> +    domid_t   domid;
> +    /* Address (0xfeeXXXXX) */
> +    uint64_t  addr;
> +    /* Data -- lower 32 bits */
> +    uint32_t  data;
> +};

Please rearrange this so that it has the same size and layout on 32-bit
and 64-bit builds. 

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel