Re: [Xen-devel] [PATCH] libxl: use preferred syntax for network device creation with upstream qemu [and 1 more messages]

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Markus Armbruster writes ("Re: [Xen-devel] [PATCH] libxl: use preferred syntax 
for network device creation with upstream qemu"):
> I figure this is a good idea.

Thanks, I'll take that as an ack.

However, sorry to nitpic, but:

Ian Campbell writes ("[Xen-devel] [PATCH] libxl: use preferred syntax for 
network device creation with upstream qemu"):
> -                flexarray_append(dm_args, libxl__sprintf(gc, 
> "nic,vlan=%d,macaddr=%s,model=%s",
> -                flexarray_append(dm_args, libxl__sprintf(gc, 
> "tap,vlan=%d,ifname=%s,script=%s",
> +                flexarray_append(dm_args, libxl__sprintf(gc, 
> "%s,netdev=net%d,mac=%s",
> +                                                         vifs[i].model, 
> vifs[i].devid, smac));
> +                flexarray_append(dm_args, libxl__sprintf(gc, 
> "type=tap,id=net%d,ifname=%s,script=%s",

This increases the number of overly-long lines.  It's very hard to
read on my screen:

> -                flexarray_append(dm_args, libxl__sprintf(gc, "nic,vlan=%d,ma
caddr=%s,model=%s",
> -                flexarray_append(dm_args, libxl__sprintf(gc, "tap,vlan=%d,if
name=%s,script=%s",
> +                flexarray_append(dm_args, libxl__sprintf(gc, "%s,netdev=net%
d,mac=%s",
> +                                                         vifs[i].model, vifs
[i].devid, smac));
> +                flexarray_append(dm_args, libxl__sprintf(gc, "type=tap,id=ne
t%d,ifname=%s,script=%s",

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel