Re: [Xen-devel] [PATCH] xen/x86: Add -Wnested-externs to CFLAGS

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2011-05-26 at 17:32 +0100, Tim Deegan wrote:
> # HG changeset patch
> # User Tim Deegan <Tim.Deegan@xxxxxxxxxx>
> # Date 1306427536 -3600
> # Node ID 73ba1d95d1ec59246e2f0a8e8a1136cd5f9d98c2
> # Parent  69fe4b8a7c0961070a626cb473d19a0770db663a
> xen/x86: Add -Wnested-externs to CFLAGS
> 
> This will catch any new extern declarations that happen actually
> inside function bodies.  Unfortunately there's no equivalent
> warning for extern declarations at rootl level in .c files.
> 
> diff -r 69fe4b8a7c09 -r 73ba1d95d1ec xen/arch/x86/Rules.mk
> --- a/xen/arch/x86/Rules.mk   Thu May 26 17:17:43 2011 +0100
> +++ b/xen/arch/x86/Rules.mk   Thu May 26 17:32:16 2011 +0100
> @@ -27,6 +27,7 @@ CFLAGS += -I$(BASEDIR)/include/asm-x86/m
>  CFLAGS += -msoft-float
>  
>  $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
> +$(call cc-option-add,CFLAGS,CC,-Wnested-externs)
                   ^ missing s?

>  
>  ifeq ($(supervisor_mode_kernel),y)
>  CFLAGS += -DCONFIG_X86_SUPERVISOR_MODE_KERNEL=1
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel