[Xen-devel] Re: [PATCH] CPUID level 0x00000007:0 (ebx) is word 9, instead of word 7

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 31.05.11 at 14:39, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
> On 31/05/2011 00:39, "Li, Xin" <xin.li@xxxxxxxxx> wrote:
> 
>> CPUID level 0x00000007:0 (ebx) is word 9, instead of word 7.
>> 
>> ... make it consistent with native Linux.
> 
> This is just a cleanup, not a bug fix?

If the patch was quoted in its entirety (didn't see the original in my
inbox), this is rather introducing a bug (since NCAPINTS is 8). I also
can't see why we would need to stay in sync with Linux's capability
array indices.

Jan

>  -- Keir
> 
>> Signed-off-by: Li Xin <xin.li@xxxxxxxxx>
>> 
>> diff -r d7c755c25bb9 xen/include/asm-x86/cpufeature.h
>> --- a/xen/include/asm-x86/cpufeature.h  Sat May 28 08:58:08 2011 +0100
>> +++ b/xen/include/asm-x86/cpufeature.h  Tue May 31 07:34:34 2011 +0800
>> @@ -142,7 +142,7 @@
>>  #define X86_FEATURE_TOPOEXT     (6*32+22) /* topology extensions CPUID 
> leafs
>> */
>> 
>>  /* Intel-defined CPU features, CPUID level 0x00000007:0 (ebx), word 9 */
>> -#define X86_FEATURE_FSGSBASE   (7*32+ 0) /* {RD,WR}{FS,GS}BASE instructions
>> */
>> +#define X86_FEATURE_FSGSBASE   (9*32+ 0) /* {RD,WR}{FS,GS}BASE instructions
>> */
>> 
>>  #define cpu_has(c, bit)                test_bit(bit, (c)->x86_capability)
>>  #define boot_cpu_has(bit)      test_bit(bit, boot_cpu_data.x86_capability)




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel