Re: [Xen-devel] libxl build errors in xen-unstable

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2011-05-31 at 09:45 +0100, Ian Campbell wrote:
> On Mon, 2011-05-30 at 17:33 +0100, Olaf Hering wrote:
> > There are new build errors in xen-unstable since revision 23368.
> > Wether the _libxl_paths.h.tmp/_libxl_paths.h errros/warnings are new, no
> > idea.
> [...]
> > cmp: _libxl_paths.h.tmp: No such file or directory
> > sed -e "s/\([^=]*\)=\(.*\)/#define \1 \2/g" _libxl_paths.h.tmp 
> > >_libxl_paths.h.2.tmp
> > if ! cmp _libxl_paths.h.2.tmp _libxl_paths.h; then mv -f 
> > _libxl_paths.h.2.tmp _libxl_paths.h; fi
> > Parsing libxl.idl
> > cmp: _libxl_paths.h: No such file or directory
> 
> Presumably this also yields the correct return code to cause the mv to
> happen, so you do end up with a _libxl_paths.h with stuff in it?

Seems to return 2 for me, so yes it works.

8<-----------------------------------

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1306831676 -3600
# Node ID 8cf4450955f43bb6e5fc07f20cacdf6e8cb80765
# Parent  acef384cf9ebbebde29b57a2fcbf2aef0b915497
libxl: avoid build warning when _libxl_types.h does not initially exist.

Olaf Hering reports:
        if ! cmp _libxl_paths.h.2.tmp _libxl_paths.h; then mv -f 
_libxl_paths.h.2.tmp _libxl_paths.h; fi
        cmp: _libxl_paths.h: No such file or directory

Use "cmp -s" to silence the error. cmp returns 2 in this case and so the mv
does occur.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r acef384cf9eb -r 8cf4450955f4 tools/libxl/Makefile
--- a/tools/libxl/Makefile      Tue May 31 09:34:20 2011 +0100
+++ b/tools/libxl/Makefile      Tue May 31 09:47:56 2011 +0100
@@ -69,7 +69,7 @@ genpath-target = $(call buildmakevars2fi
 
 _libxl_paths.h: genpath
        sed -e "s/\([^=]*\)=\(.*\)/#define \1 \2/g" $@.tmp >$@.2.tmp
-       if ! cmp $@.2.tmp $@; then mv -f $@.2.tmp $@; fi
+       if ! cmp -s $@.2.tmp $@; then mv -f $@.2.tmp $@; fi
 
 libxl_paths.c: _libxl_paths.h
 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel