Re: [Xen-devel] [xen-unstable bisection] complete test-i386-xcpkern-i386-pv

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [xen-unstable bisection] complete 
test-i386-xcpkern-i386-pv"):
> On Fri, 2011-06-03 at 09:58 +0100, Ian Jackson wrote:
...
> >       tools/hotplug: support vif-post.d hook arrangements
> >       
> >       New feature: you can drop hook scripts into
> >        /etc/xen/scripts/vif-post.d/*.hook
> >       
> >       Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >       Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

I had a suspicion it might be that ...

> That message comes from the "trap sigerr ERR". The hotplug script has
> "set -e" so some command has failed.

It's a shame that we don't get the stderr output under xend.  Still,
let's not try to fix that ...

> My guess is that when there are no hooks at all this:
>     for f in /etc/xen/scripts/${1}-${2}.d/*.hook; do
>         [ -x "$f" ] && . "$f"
>     done
> 
> expands into a literal
>       [ -x ".....*.hook" ] && . "..... *.hook"
> 
> and since ....*.hook doesn't exist the overall result of this expression
> is failure. The same would happen for any *.hook which wasn't
> executable.

No.

mariner:~> bash -ec 'trap "echo e" ERR; false && echo a; echo b'
b
mariner:~> dash -ec 'for f in /etc/xen/scripts/${1}-${2}.d/*.hook; do [ -x "$f" 
] && . "$f"; done; echo ok'
ok
mariner:~> ls /etc/xen/scripts
/bin/ls: cannot access /etc/xen/scripts: No such file or directory
mariner:~>

set -e and the ERR trap don't apply to && and || lists at all.  This
is arguably a specification bug.

> Perhaps the following helps?

I think we need more diagnosis.  I'll investigate.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel