Re: [Xen-devel] [PATCH] libxl: use '-name' instead of deprecated '-domain-name' for device model

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 7 Jun 2011, Wei Liu wrote:
> On Tue, Jun 7, 2011 at 7:52 PM, Stefano Stabellini
> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > On Tue, 7 Jun 2011, Wei Liu wrote:
> >> commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
> >> Author: Wei Liu <liuw@xxxxxxxxx>
> >> Date: Â Tue Jun 7 14:26:34 2011 +0800
> >>
> >> Â Â libxl: use '-name' instead of deprecated '-domain-name' for device 
> >> model.
> >>
> >> Â Â This unifies upstream qemu and Xen's qemu-dm startup option.
> >>
> >> Â Â Signed-off-by: Wei Liu <liuw@xxxxxxxxx>
> >>
> >> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> >> index 47a51c8..d53a20d 100644
> >> --- a/tools/libxl/libxl_dm.c
> >> +++ b/tools/libxl/libxl_dm.c
> >> @@ -95,7 +95,7 @@ static char ** 
> >> libxl__build_device_model_args_old(libxl__gc *gc,
> >> Â Â Â Â Â Â Â Â Â Â Â Â"-d", libxl__sprintf(gc, "%d", info->domid), NULL);
> >>
> >> Â Â Âif (info->dom_name)
> >> - Â Â Â Âflexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
> >> + Â Â Â Âflexarray_vappend(dm_args, "-name", info->dom_name, NULL);
> >>
> >> Â Â Âif (info->vnc) {
> >> Â Â Â Â Âchar *vncarg;
> >
> > considering that libxl__build_device_model_args_old is only meant to be
> > used with the old qemu-xen that we are not going to upgrade anymore, I
> > don't think it is worth to try to update its command line options.
> >
> 
> Well, the device_model_{override,version} are not working for pv now.
> So I consider this patch a workaround for using upstream qemu as pure
> pv backend.
> 
> I'm still waiting for IanJ's re-factoring of libxl. Hope that could
> get a better implementation.
> 

IanJ is not going to touch this code AFAIK, so you can go ahead and
write a proper patch for that.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel