RE: [Xen-devel] [PATCH] xen-tmem: Build cleancache shim to Xen Transcendent Memory only if Cleancache is enabled

[Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>]

> From: Nikanth Karthikesan [mailto:nikanth@xxxxxxxxxx]
> Sent: Tuesday, June 14, 2011 2:43 AM
> To: Jan Beulich
> Cc: Dan Magenheimer; Jeremy Fitzhardinge; xen-devel@xxxxxxxxxxxxxxxxxxx; 
> Konrad Wilk
> Subject: RE: [Xen-devel] [PATCH] xen-tmem: Build cleancache shim to Xen 
> Transcendent Memory only if
> Cleancache is enabled
> 
> On Tue, 2011-06-14 at 09:29 +0100, Jan Beulich wrote:
> > >>> On 13.06.11 at 16:58, Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> 
> > >>> wrote:
> > >>  +obj-$(CONFIG_CLEAN_CACHE)      += tmem.o
> > >
> > > Hi Nikanth --
> > >
> > > Thanks for the suggested patch.  However, tmem.c works with both
> > > cleancache and frontswap... the shim in place only works with
> > > cleancache but there is a posted patch for it to work with
> > > frontswap as well.  So your patch would just need to be
> > > redone when frontswap is included soon.
> > >
> > > BUT... is there a way to do an inclusive-or operation
> > > in a Makefile?... something like this (though I know this
> > > exact syntax won't work)...
> > >
> > > obj-($CONFIG_CLEANCACHE||$CONFIG_FRONTSWAP)
> >
> > You can specify the same object more than once, i.e.
> >
> > obj-$(CONFIG_CLEAN_CACHE)   += tmem.o
> > obj-$(CONFIG_FRONTSWAP)     += tmem.o
> >
> 
> Cool!
> 
> So, can this patch be merged then? It would be easy to patch for
> frontswap, in the frontswap patchset.

I'm OK with the Makefile change, but the second part of your patch
that removes the #ifdef CONFIG_CLEANCACHE will just need to be
put in again when frontswap is added (as it will be possible that
CONFIG_FRONTSWAP=y but CONFIG_CLEANCACHE=n).

Is there a rush on this (i.e. is the compiler warning impeding
your work somehow)? As I said, it should all be cleaned up soon
so would prefer not to submit these piecemeal.

Thanks,
Dan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel