[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RESENTv2] libxl: add all pci devices to xenstore at once (during VM create)



iwj writes ("Re: [Xen-devel] [PATCH RESENTv2] libxl: add all pci devices to 
xenstore at once (during VM create)"):
> Marek Marczykowski writes ("[Xen-devel] [PATCH RESENTv2] libxl: add all pci 
> devices to xenstore at once (during VM create)"):
> > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> > --- a/tools/libxl/libxl_create.c
> > +++ b/tools/libxl/libxl_create.c
> > @@ -521,6 +521,11 @@ static int do_domain_create(libxl__gc *g
> >  
> >      for (i = 0; i < d_config->num_pcidevs; i++)
> >          libxl__device_pci_add(gc, domid, &d_config->pcidevs[i], 1);
> > +    ret = libxl__create_pci_backend(gc, domid, d_config->pcidevs, d_confi
g->num_pcidevs);
> > +    if (ret < 0) {
> > +        LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "libxl_create_pci_backend faile
d: %d", ret);
> > +        goto error_out;
> > +    }
> 
> There is an indenting error here.

Oh wait, no there isn't.  I blame being distracted by the wrap damage.

> Also your lines are still >75 characters.  Please wrap them
> appropriately, including splitting strings if necessary.

I will fix up the formatting and apply the patch.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.