Re: [Xen-devel] [PATCH V4] libxl, Introduce a QMP client

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Mon, Jun 20, 2011 at 15:50, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> anthony.perard@xxxxxxxxxx writes ("[Xen-devel] [PATCH V4] libxl, Introduce a 
> QMP client"):
>> QMP stands for QEMU Monitor Protocol and it is used to query information
>> from QEMU or to control QEMU.
>
> Thanks for this; it's coming along. ÂI have some comments....
>

[...]

>> +/* QMP Command that can be send */
>> +enum libxl__qmp_command_e {
>> + Â ÂQMP_COMMAND_QUERY_CHARDEV,
>> + Â ÂQMP_COMMAND_NUMBER,
>> +};
> ...
>> +_hidden int libxl__qmp_send_command(libxl__qmp_handler *qmp, 
>> libxl__qmp_command_e command);
>
> I'm not entirely convinced by this interface. ÂWouldn't it be better
> to have a specific function for each command ? ÂAfter all commands may
> have arguments. ÂSomething like:
>
> _hidden int libxl__qmp_send_query_chardev(libxl__qmp_handler *qmp);

Indeed, it should be better to have specific functions. Some commands
will have arguments. And have a generic function for all of them will
maybe not be easy and not clear.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel