Re: [Xen-devel] [PATCH] tools: fix build after recent xenpaging changes

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Fri, 2011-06-24 at 14:57 +0100, Olaf Hering wrote:
> On Fri, Jun 24, Ian Campbell wrote:
> 
> > In fact since the page-in thread is doing relatively expensive work I'd
> > expect that the trigger loop would get to run several iterations for
> > each time the page-in loop ran..
> 
> That did not happen for me, I will think about it.

It possibly doesn't matter, based on hat you said below, since you will
come back round and try again. It makes the existing locking a bit
pointless though I think, since you are in "fast-and-lose-mode" already.

> > > If the caller of page_in_trigger will find the gfn is still in paging
> > > state, it will just try again.
> > 
> > I don't see where it would go back and try page 1 again if it gets
> > missed (as in the above example)
> 
> The break exits the for() loop, not the while(1). In the next iteration
> page 1 may still be in paging->bitmap and tried again.

I'd missed the interrupted -> 1 in the while loop. I presume there is
some other exit condition which triggers once everything has been paged
back in and actually causes the daemon to exit?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel