[Xen-devel] Re: [Qemu-devel] [PATCH 2/2] xen: add vkbd support for PV on HVM guests

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 24 Jun 2011, Peter Maydell wrote:
> On 24 June 2011 15:54,  <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> 
> > + Â Âif (!in->c.ds) {
> > + Â Â Â Âchar *vfb = xenstore_read_str(NULL, "device/vfb");
> > + Â Â Â Âif (vfb == NULL) {
> > + Â Â Â Â Â Â/* there is no vfb, run vkbd on its own */
> > + Â Â Â Â Â Âin->c.ds = get_displaystate();
> > + Â Â Â Â} else {
> > + Â Â Â Â Â Âfree(vfb);
> 
> xenstore_read_str() returns a pointer from a qemu_strdup()
> so strictly this should be a qemu_free(), I think?
 
Yes, it should be, I'll send a second version of the patch.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel