Re: [Xen-devel] [PATCH] tools/pygrub: fix solaris kernel sniff

[Zhigang Wang <zhigang.x.wang@xxxxxxxxxx>]

On 07/08/2011 01:16 PM, Ian Jackson wrote:
> Zhigang Wang writes ("[Xen-devel] [PATCH] tools/pygrub: fix solaris kernel 
> sniff"):
>> tools/pygrub: fix solaris kernel sniff
>>
>> Solaris 11 build 163+ removes '/platform/i86xpv/kernel/unix' and only the
>> 64-bit PV kernel file '/platform/i86xpv/kernel/amd64/unix' exists.
> Thanks but I'm not sure this is right.
>
> Previously, if none of the Solaris files in /platform exist, this code
> would unconditionally exit.
>
> Now you have moved the relevant return inside the
>    if not cfg["kernel"]:
> so that on a non-Solaris platform if cfg["kernel"] is not set we will
> always do the "Unpleasant" tweaks.
>
> I don't think that's correct.
>
> Ian.
Yes. I agree.

What about attached patch?

zhigang

Attachment: xen-pygrub-fix-solaris-kernel-sniff
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel