Re: [Xen-devel] [PATCH] Fix xencommons for NetBSD

[Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>]

It works fine on NetBSD too, but just to be on the safe side I've
changed it. Thanks.

2011/7/15 Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>:
> On Fri, 2011-07-15 at 12:44 +0100, Olaf Hering wrote:
>> On Fri, Jul 15, Roger Pau Monnà wrote:
>>
>> > Another one, used -n instead of -z when testing the presence of
>> > XENSTORED_ROOTDIR. Sorry for this mess, I'm not really used to make
>> > shell init scripts.
>>
>> + Â Â Â xenstored_pid=$(check_pidfile ${XENSTORED_PIDFILE} 
>> ${SBINDIR}/xenstored)
>> + Â Â Â if test -z $xenstored_pid; then
>>
>> Doesnt this expand to 'if test -z ; then' if check_pidfile returns
>> nothing, causing a shell syntax error?
>
> Seems not:
> $ dash -c 'if test -z ; then echo foo ; fi'
> foo
> $ posh -c 'if test -z ; then echo foo ; fi'
> foo
>
> (maybe NetBSD sh(1) or test(1) differs though)
>
>> Better do 'if test -z "$variable" ; then'.
>
> That's still good advice IMHO.
>
> Ian.
>
>
>

Attachment: patch-xencommons
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel