Re: [Xen-devel] [PATCH] Fix xend restarting problem on NetBSD

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monné writes ("Re: [Xen-devel] [PATCH] Fix xend restarting problem on 
NetBSD"):
> While searching for a man page to show you the check_pidfile options
> I've found that you can also set a variable with the path to the
> interpreter, so no need to expand the script.

Thanks.  This version is much nicer :-).  I still have a couple of
questions.  Please forgive my ignorance about NetBSD.

> +PATH="${PATH}:${SBINDIR}"
> +export PATH

Is SBINDIR not on the path for root's daemon processes ?  Perhaps we
are doing something else wrong for NetBSD (perhaps we should be using
libexec) ?

> +command_interpreter=`head -n 1 ${command} | awk '{ print substr($0,3) }'`

Why does it need to know that ?  I'm happy to believe that it does,
but if so I would have expected to find that there was a ready-made
utility on NetBSD that avoids having to open-code a rune like the one
above.

> The only strange thing is that I have to use SIGKILL to kill xend,
> SIGTERM seems to do nothing

That's probably a bug in the xend python code.  But I don't expect
we'll try to fix that at this point.

> (also xend spawns two processes, but I guess this is normal).

Yes.

> Attached an updated patch, with a simpler script.

Thanks.  I think my comments so far are small enough (and xend
sufficiently deprecated) that I've applied it.  If you would like to
further improve it in the light of my questions above please submit
patches which will apply on top of that one.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel