[Xen-devel] Re: [PATCH V7 2/7] libxl: Add get/set_default_namespace in libxltypes.py.

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, 21 Jul 2011, Ian Campbell wrote:

> On Wed, 2011-07-20 at 22:24 +0100, Anthony PERARD wrote:
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>
> I'm not sure if it matters but default_namespace should possibly be
> private to the module (__ at the start)? Perhaps get_default_namesspace
> too, probably neither .idl files nor gen*.py should ever need to query
> this, they should use the info in specific types.

Ok, I will change names but use only one '_' for "private"
function/variable.

> If I were prone to bikeshedding I'd suggest that "set_default_namespace"
> could be just "namespace" since it would read nicer in the .idl files.

:), I'll change that too.

> In any case that's all nit picking so:
>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel