[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] libxl: added libxl compatibility with physical backend file for NetBSD
On 07/22/11 15:39, Ian Campbell wrote: On Fri, 2011-07-22 at 13:38 +0100, Roger Pau Monnà wrote:Hello, This patch fixes the problems described in a previous thread regarding PV machines not booting on NetBSD with libxl toolstack. The patch also prevents libxl from adding PCI entries to xenstore if there is no PCI device configured in the guest.Thanks Roger. In general we prefer to see individual fixes split up into separate patches for review and commit. Also please can you add to your ~/.hgrc: [diff] showfunc = True It prints the function name in the hunk header which makes it easier to review. The change to the hotplug script seems odd, if the "xtype" paramter is not needed then just remove it altogether, otherwise we need to teach libxl what to write. The PCI change looks good, although you might as well throw the for() loop under the check too. "#ifdef" etc should be in column 0, but the content should be indented normally. Ack. The checks on LIBXL_DISK_FORMAT_EMPTY and S_ISBLK are not really related so I would not combine them even though the return is the same. Otherwise the HAVE_PHY_BACKEND_FILE_SUPPORT change itself looks ok What is DONT_REMOVE_VBD_FROM_STORE for? Is this because xenbackendd does it for you or something else? The hotplug script invoked by xenbackendd removes the vbd entry via xenstored-rm. Does your changed xenbackendd still work with xend? Oh, I see what the hotplug script change was about now -- I guess just remove the commented out line? Ack. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |